Add alternative auth mechanism for API usage #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simenheg
reviewed
Aug 17, 2023
There was a problem hiding this comment.
LVGTM! Noen spørsmål:
- Burde vi som nevnt kanskje plassert den et annet sted enn under "Admin" som forsvinner snart først som sist, slik at ikke brukerne trenger å lære seg dette to ganger?
- Litt lett å misse at man kan gi integrasjonen et navn; burde man kanskje startet med den modalen der man skriver inn navn og beskrivelse når man trykker på "Legg til klient"?
- Tror vi burde hashe secretene som vi lagrer i databasen for sikkerhets skyld.
- Lenke til API-dokumentasjonen fra et sted på siden?
- Burde kanskje få på rate limiting som vi snakket om.
- Er c67350a rebaset eller noe inn her med en feil?
petterhj
force-pushed
the
protect-api-secrets
branch
from
7bf6a6f to
fc5b0af
Compare
petterhj
force-pushed
the
protect-api-secrets
branch
from
f8a4999 to
bd8feaa
Compare
simenheg
approved these changes
Oct 31, 2023
Comment on lines
+16
to
+20
| const apiLimiter = rateLimit({ | ||
| windowMs: 15 * 60 * 1000, // 15 minutes | ||
| max: 100, // max 100 requests per window | ||
| message: 'Too many requests, please try again later.', | ||
| }); |
petterhj
force-pushed
the
protect-api-secrets
branch
from
bd8feaa to
e9bfa45
Compare
petterhj
force-pushed
the
protect-api-secrets
branch
from
e9bfa45 to
e180685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.